-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXP][Command-Buffer] Optimize L0 command buffer submission #1442
[EXP][Command-Buffer] Optimize L0 command buffer submission #1442
Conversation
4e5741a
to
4e53710
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
- Coverage 14.82% 12.43% -2.40%
==========================================
Files 250 241 -9
Lines 36220 36248 +28
Branches 4094 4111 +17
==========================================
- Hits 5369 4506 -863
- Misses 30800 31738 +938
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
f264346
to
8718fe1
Compare
8718fe1
to
05e3e6d
Compare
2eab7d0
to
3cce4c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3cce4c0
to
c9647a3
Compare
@oneapi-src/unified-runtime-maintain @oneapi-src/unified-runtime-level-zero-write Pinging for reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @raiyanla , can you give this a check since you authored the in order lists changes?
c9647a3
to
2c56c47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's conflicts that needs resolved in the rebase of this PR by using replacing urPrint
with logger::debug
e5f41c9
to
3f85f30
Compare
Updated DPC++ PR to remove dependency on SYCL runtime changes. |
5d0ee3f
to
9f3ae22
Compare
- Adds command buffer property to explicitly enable profiling - Add ability to enforce use of in-order command lists
9f3ae22
to
bb45b7c
Compare
- Bumps commit only and includes minimal pi2ur changes for new descriptor members - In-order path not currently used, enable profiling by default (match previous behaviour) UR PR: oneapi-src/unified-runtime#1442
Draft DPC++ PR: intel/llvm#13565