Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXP][Command-Buffer] Optimize L0 command buffer submission #1442

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Mar 14, 2024

  • Adds command buffer property to explicitly enable profiling
  • Add ability to enforce use of in-order command lists

Draft DPC++ PR: intel/llvm#13565

@Bensuo Bensuo force-pushed the ben/optimize-cmdbuffer-submission branch 4 times, most recently from 4e5741a to 4e53710 Compare March 18, 2024 17:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 12.43%. Comparing base (78ef1ca) to head (05e3e6d).
Report is 194 commits behind head on main.

Files Patch % Lines
include/ur_print.hpp 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
- Coverage   14.82%   12.43%   -2.40%     
==========================================
  Files         250      241       -9     
  Lines       36220    36248      +28     
  Branches     4094     4111      +17     
==========================================
- Hits         5369     4506     -863     
- Misses      30800    31738     +938     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bensuo Bensuo force-pushed the ben/optimize-cmdbuffer-submission branch 3 times, most recently from f264346 to 8718fe1 Compare March 21, 2024 12:25
@Bensuo Bensuo marked this pull request as ready for review March 21, 2024 14:41
@Bensuo Bensuo requested review from a team as code owners March 21, 2024 14:41
scripts/core/EXP-COMMAND-BUFFER.rst Outdated Show resolved Hide resolved
source/adapters/level_zero/command_buffer.hpp Outdated Show resolved Hide resolved
@Bensuo Bensuo force-pushed the ben/optimize-cmdbuffer-submission branch from 8718fe1 to 05e3e6d Compare March 21, 2024 17:55
@Bensuo Bensuo force-pushed the ben/optimize-cmdbuffer-submission branch 2 times, most recently from 2eab7d0 to 3cce4c0 Compare April 2, 2024 12:10
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bensuo Bensuo force-pushed the ben/optimize-cmdbuffer-submission branch from 3cce4c0 to c9647a3 Compare April 2, 2024 13:44
@Bensuo
Copy link
Contributor Author

Bensuo commented Apr 3, 2024

@oneapi-src/unified-runtime-maintain @oneapi-src/unified-runtime-level-zero-write Pinging for reviews

Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @raiyanla , can you give this a check since you authored the in order lists changes?

@kbenzie kbenzie added loader Loader related feature/bug specification Changes or additions to the specification level-zero L0 adapter specific issues labels Apr 10, 2024
@Bensuo Bensuo added the ready to merge Added to PR's which are ready to merge label Apr 16, 2024
@Bensuo Bensuo force-pushed the ben/optimize-cmdbuffer-submission branch from c9647a3 to 2c56c47 Compare April 16, 2024 11:34
@github-actions github-actions bot added the experimental Experimental feature additions/changes/specification label Apr 16, 2024
@github-actions github-actions bot added the command-buffer Command Buffer feature addition/changes/specification label Apr 16, 2024
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's conflicts that needs resolved in the rebase of this PR by using replacing urPrint with logger::debug

@Bensuo Bensuo force-pushed the ben/optimize-cmdbuffer-submission branch 3 times, most recently from e5f41c9 to 3f85f30 Compare April 24, 2024 12:29
@Bensuo
Copy link
Contributor Author

Bensuo commented Apr 25, 2024

Updated DPC++ PR to remove dependency on SYCL runtime changes.

@EwanC EwanC force-pushed the ben/optimize-cmdbuffer-submission branch 2 times, most recently from 5d0ee3f to 9f3ae22 Compare April 26, 2024 13:09
- Adds command buffer property to explicitly enable profiling
- Add ability to enforce use of in-order command lists
@EwanC EwanC force-pushed the ben/optimize-cmdbuffer-submission branch from 9f3ae22 to bb45b7c Compare April 26, 2024 13:30
@kbenzie kbenzie merged commit 7371150 into oneapi-src:main Apr 26, 2024
51 checks passed
sommerlukas pushed a commit to intel/llvm that referenced this pull request Apr 29, 2024
- Bumps commit only and includes minimal pi2ur changes for new
descriptor members
- In-order path not currently used, enable profiling by default (match
previous behaviour)

UR PR: oneapi-src/unified-runtime#1442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-buffer Command Buffer feature addition/changes/specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues loader Loader related feature/bug ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants